]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
extensionDownloader: Only check server if there's something to update
authorFlorian Müllner <fmuellner@gnome.org>
Sun, 15 Mar 2020 22:41:27 +0000 (23:41 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Tue, 17 Mar 2020 13:56:49 +0000 (13:56 +0000)
checkForUpdates() will currently always query the server for updates,
even when passing an empty vardict of installed extensions. We know
there won't be any updates in that case, so avoid a pointless network
request.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1100

js/ui/extensionDownloader.js

index 5f6e74b09daad87e30feb105826de6427d280475..be7426be098214d4d4a9c1e199919ea6b521d1a4 100644 (file)
@@ -127,6 +127,9 @@ function checkForUpdates() {
         metadatas[uuid] = extension.metadata;
     });
 
+    if (Object.keys(metadatas).length === 0)
+        return; // nothing to update
+
     let versionCheck = global.settings.get_boolean(
         'disable-extension-version-validation');
     let params = {